Skip to content

Fix Plex debounce wrapper#33730

Merged
balloob merged 2 commits intohome-assistant:devfrom
jjlawren:plex_debounce_followup
Apr 6, 2020
Merged

Fix Plex debounce wrapper#33730
balloob merged 2 commits intohome-assistant:devfrom
jjlawren:plex_debounce_followup

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Apr 6, 2020

Proposed change

The debouncer for Plex added in #33560 wasn't done properly and mixed sync & async which allowed races to occur. This converts the wrapped method and its dependencies to async.

Calls to the refresh method from the media_player services were no longer necessary as the update mechanism is now push via websocket. All of these are now removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/plex/server.py Outdated
Comment thread homeassistant/components/plex/server.py Outdated
@balloob balloob added this to the 0.108.0 milestone Apr 6, 2020
@balloob balloob merged commit 6dfffb2 into home-assistant:dev Apr 6, 2020
balloob pushed a commit that referenced this pull request Apr 6, 2020
* Fix debounce wrapper by converting to async

* Review suggestions
@jjlawren jjlawren deleted the plex_debounce_followup branch April 6, 2020 18:29
Comment thread homeassistant/components/plex/server.py
@jjlawren jjlawren mentioned this pull request Apr 7, 2020
20 tasks
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants